fix(ci): Fix docs.rs build + security workflow + standardize badges#8
Closed
Lenvanderhof wants to merge 1 commit intomainfrom
Closed
fix(ci): Fix docs.rs build + security workflow + standardize badges#8Lenvanderhof wants to merge 1 commit intomainfrom
Lenvanderhof wants to merge 1 commit intomainfrom
Conversation
## reasonkit-mem (0.1.5) - Use nightly Rust for CI docs job (required for docsrs features) - Use --features compression to match docs.rs metadata - Add deny.toml for cargo-deny security checks - Standardize badges with consistent styling and brand colors - Add Downloads badge ## reasonkit-web (0.1.6) - Use --features full instead of --all-features for CI docs - Add deny.toml for cargo-deny security checks - Standardize badges with consistent styling and brand colors - Add Downloads badge ## reasonkit-core - Add Security badge - Add docs.rs badge (replaces custom docs badge) - Add Downloads badge - Standardize badge styling with brand colors ## reasonkit (meta-crate) - Center-align README header - Add Security badge placeholder (no workflow yet) - Add Downloads badge - Standardize badge styling with brand colors All repos now have consistent badge sets: - CI, Security, Crates.io, docs.rs, Downloads, License, Rust MSRV Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses three key operational improvements: fixing the docs.rs documentation build, adding cargo-deny security configuration, and standardizing README badges for consistent presentation.
Changes:
- Modified docs build to use
--features fullinstead of--all-featuresto avoid wasm32 dependency issues - Added comprehensive
deny.tomlconfiguration for cargo-deny security audits with advisory ignores - Updated README badges with consistent flat-square styling and brand colors
- Version bump from 0.1.5 to 0.1.6
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Changed docs build from --all-features to --features full to match docs.rs configuration |
deny.toml |
Added cargo-deny configuration with security advisories, license checks, and dependency validation rules |
README.md |
Standardized badge styling with consistent colors, added downloads badge, and improved visual consistency |
Cargo.toml |
Version bump to 0.1.6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "aarch64-apple-darwin", | ||
| "x86_64-pc-windows-msvc", | ||
| ] | ||
| all-features = true |
There was a problem hiding this comment.
The all-features = true setting in the graph configuration will enable the wasm feature, which requires the wasm32 target that is not included in the targets list. This is inconsistent with the CI workflow change that specifically avoids wasm features. Consider either:
- Changing this to
features = ["full"]to match the CI and docs.rs configuration, or - Adding
wasm32-unknown-unknownto the targets list if wasm support is needed for cargo-deny checks.
Suggested change
| all-features = true | |
| features = ["full"] |
Contributor
Author
|
This PR has merge conflicts after the batch dependency update PR #7 was merged. Needs manual rebase to resolve conflicts before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--features fullinstead of--all-features(avoids wasm32 deps)deny.tomlconfigurationChanges
.github/workflows/ci.yml: Use--features fullfor docs jobdeny.toml: Add cargo-deny configuration with advisory ignoresREADME.md: Rich, consistent badge system with brand colorsCargo.toml: Version bump to 0.1.6Test Plan
🤖 Generated with Claude Code